Skip to content

gh-112068: C API: Add support of nullable arguments in PyArg_Parse (prefix) #121187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

gh-112068: C API: Add support of nullable arguments in PyArg_Parse (prefix) #121187

wants to merge 4 commits into from

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 30, 2024 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka changed the title C API: Add support of nullable arguments in PyArg_Parse gh-112068: C API: Add support of nullable arguments in PyArg_Parse Jun 30, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jun 30, 2024
Closed
@serhiy-storchaka serhiy-storchaka changed the title gh-112068: C API: Add support of nullable arguments in PyArg_Parse gh-112068: C API: Add support of nullable arguments in PyArg_Parse (prefix) Jul 3, 2024
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 3, 2024
Merged
picnixz
picnixz reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now in favor of the prefix implementation (see the comment on the sister's PR). I'd be interested in implementing the (...) parsing though (I assume it has to be with grouping in general, like ?(...) means that everything inside (...) is optional?).

@serhiy-storchaka
Copy link
Member Author

I assume it has to be with grouping in general, like ?(...) means that everything inside (...) is optional?

No, it means that the argument can be a sequence of particular length or None. This feature is implemented in this PR, but not in the sister's PR.

@serhiy-storchaka
Copy link
Member Author

Closed in favor of #121303.

@serhiy-storchaka serhiy-storchaka deleted the pyarg_parse-nullable branch January 8, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @picnixz